Skip to content

Conversation

Bhup-GitHUB
Copy link

@Bhup-GitHUB Bhup-GitHUB commented Oct 10, 2025

Description

Fixes JavaScript linting error in @stdlib/ndarray/ctor test file by replacing new Array() constructor with array literal.

Changes

  • Replaced new Array(shape.length+1) with array literal and explicit length assignment
  • Resolves stdlib/no-new-array ESLint rule violation
  • Maintains identical functionality while adhering to project coding standards

Related Issues

Resolves the linting failure detected in CI workflow:
https://github.com/stdlib-js/stdlib/actions/runs/18392323945

Testing

  • ✅ Local linting passes (no errors detected)
  • ✅ No functional changes - only coding style compliance
  • ✅ Array behavior remains identical

Checklist

  • Read, understood, and followed the contributing guidelines
  • Linting passes locally
  • No functional changes - only coding style compliance
  • Commit message follows project conventions
  • Single focused change addressing one specific issue

- Replace 'new Array(shape.length+1)' with array literal and length assignment
- Fixes stdlib/no-new-array linting error in test.instance.set_nd.js
- Maintains same functionality while adhering to project coding standards
- Resolves JavaScript linting failure detected in CI workflow
@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Oct 10, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
ndarray/ctor $\color{red}801/806$
$\color{green}+99.38\%$
$\color{red}109/112$
$\color{green}+97.32\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{red}801/806$
$\color{green}+99.38\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants